Dangerous loud noises or Direct Current out

Found a bug ? Report here

Re: Dangerous loud noises or Direct Current out

Postby adegert » Fri Oct 14, 2011 10:44 pm

ok.... embarrassing error..
Should be gone when you add the & (not sure if 0.19 was really rev1210 but the
code should look like that). The error doesn't occur when the system samplerate
and the impulse response data samplerate (48000) are equal.

Code: Select all
Index: gx_convolver.cpp
===================================================================
--- gx_convolver.cpp   (Revision 1210)
+++ gx_convolver.cpp   (Arbeitskopie)
@@ -422,7 +422,7 @@
     float *vec;
 public:
     CheckResample(): vec(0) {}
-    float *resample(int count, float *impresp, unsigned int samplerate) {
+    float *resample(int& count, float *impresp, unsigned int samplerate) {
    if (samplerate != gx_jack::gxjack.jack_sr) {
        vec = gx_resample::_glob_resamp->_buffer_resampler.process(samplerate, count, impresp, gx_jack::gxjack.jack_sr, count);
        if (!vec) {
User avatar
adegert
Site Admin
 
Posts: 142
Joined: Fri Jan 22, 2010 11:16 pm

Re: Dangerous loud noises or Direct Current out

Postby Tim E Real » Sat Oct 15, 2011 4:35 am

Oh my... Good catch on that reference. The ol' compiler let that one through.

Test OK here, of course. :)

---
PS Just a side note. When starting Guitarix I get:
"JackGraphManager::Connect already connected port_src = 31 port_dst = 29"

Not sure if that's just informational, looks not. I think one can ask Jack if a port is
already connected. Maybe try checking first...

Thanks so much for your help. We be rockin' now.
Tim.
Tim E Real
 

Previous

Return to Bug reports

Who is online

Users browsing this forum: No registered users and 1 guest

cron